Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added several chain controls #29161

Merged
merged 14 commits into from
Dec 4, 2024
Merged

Added several chain controls #29161

merged 14 commits into from
Dec 4, 2024

Conversation

joshuahansel
Copy link
Contributor

Refs #28948

@joshuahansel joshuahansel self-assigned this Nov 27, 2024
@moosebuild
Copy link
Contributor

moosebuild commented Nov 28, 2024 •
edited
Loading

Job Documentation, step Docs: sync website on 4ac8a27 wanted to post the following:

View the site here

This comment will be updated on new commits.

GiudGiud
GiudGiud reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@GiudGiud GiudGiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

framework/doc/content/source/chaincontrols/LimitChainControl.md Outdated Show resolved Hide resolved
framework/doc/content/source/chaincontrols/ScaleOldChainControl.md Outdated Show resolved Hide resolved
framework/include/chaincontrols/LimitChainControl.h Show resolved Hide resolved
framework/include/chaincontrols/LimitChainControl.h Outdated Show resolved Hide resolved
framework/doc/content/source/chaincontrols/RealToBoolChainControl.md Show resolved Hide resolved
test/tests/chaincontrols/pid_chain_control/gold/pid_chain_control_out.csv Outdated Show resolved Hide resolved
@joshuahansel joshuahansel requested a review from GiudGiud December 4, 2024 13:32
@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on 4ac8a27 wanted to post the following:

Framework coverage

cedfd0 #29161 4ac8a2
Total Total +/- New
Rate 85.14% 85.16% +0.02% 96.26%
Hits 107658 107846 +188 180
Misses 18792 18791 -1 7

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@joshuahansel joshuahansel merged commit 522f765 into idaholab:next Dec 4, 2024
51 checks passed
@joshuahansel joshuahansel deleted the more-chain-controls branch December 4, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiudGiud GiudGiud GiudGiud approved these changes

@lindsayad lindsayad Awaiting requested review from lindsayad lindsayad is a code owner

@roystgnr roystgnr Awaiting requested review from roystgnr roystgnr is a code owner

Assignees

@joshuahansel joshuahansel

Labels
PR: Failed but allowed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuahansel @moosebuild @GiudGiud